-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Bug 1886894 Clear sessionStorage in browsingData remove options #28261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bug 1886894 Clear sessionStorage in browsingData remove options #28261
Conversation
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
webextensions/api/browsingData.json
Outdated
| "version_added": "57", | ||
| "notes": "`removalOptions.since` is not supported." | ||
| "notes": [ | ||
| "`removalOptions.since` is not supported.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clarity, I think that it makes sense to remove this note, and introduce a "since" key that explicitly declares support etc. That makes it more visible.
Chromium browsers support it, Firefox does not (rejects with error), Safari does not support the browsingData API at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rob--W I've eliminated all of the notes regarding removalOptions.since and move the information to explicit declarations.
Co-authored-by: Rob Wu <rob@robwu.nl>
…o Bug-1886894-Clear-sessionStorage-in-browsingData-remove-options
Summary
This PR addresses the dev-docs needed requirements of Bug 1886894 Clear sessionStorage in browsingData.remove() for parity with "Clear Cookies and Site Data". It includes notes on
browsingData.removeLocalStorageandbrowsingData.removeabout the removal of session storage.Related issues
Related content changes in PR mdn/content#41609