Skip to content

Log to monarch_executions directly #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Log to monarch_executions directly #1988

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36fa53d
Allow disallowed time methods (#1974)
thomasywang Dec 2, 2025
f577eab
Log to monarch_executions directly (#1988)
thomasywang Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions hyperactor_telemetry/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
*/

#![allow(internal_features)]
#![allow(clippy::disallowed_methods)] // hyperactor_telemetry can't use hyperactor::clock::Clock (circular dependency)
#![feature(assert_matches)]
#![feature(sync_unsafe_cell)]
#![feature(mpmc_channel)]
Expand Down Expand Up @@ -649,6 +650,7 @@ pub fn initialize_logging_with_log_prefix(
tracing::debug!("logging already initialized for this process: {}", err);
}
let exec_id = env::execution_id();
// setting target to "execution" will prevent the monarch_tracing scuba client from logging this
tracing::info!(
target: "execution",
execution_id = exec_id,
Expand All @@ -664,6 +666,20 @@ pub fn initialize_logging_with_log_prefix(
revision = build_info::BuildInfo::get_revision(),
"logging_initialized"
);
// here we have the monarch_executions scuba client log
meta::log_execution_event(
&exec_id,
&Env::current().to_string(),
std::env::args().collect(),
build_info::BuildInfo::get_build_mode(),
build_info::BuildInfo::get_compiler(),
build_info::BuildInfo::get_compiler_version(),
build_info::BuildInfo::get_rule(),
build_info::BuildInfo::get_package_name(),
build_info::BuildInfo::get_package_release(),
build_info::BuildInfo::get_upstream_revision(),
build_info::BuildInfo::get_revision(),
);

if !is_layer_disabled(DISABLE_OTEL_METRICS) {
otel::init_metrics();
Expand Down