Close channel when NetRx is being stopped #2010
Closed
+116
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
pzhan9
force-pushed
the
export-D87926632
branch
from
ff0ce59 to
4751fa9
Compare
pzhan9
added a commit
to pzhan9/monarch-1
that referenced
this pull request
Dec 1, 2025
Summary: When `NetRx` is stopped, we should let its `NetTx` half know as well, so it will exit too and stop reconnecting. Otherwise, those reconnections would all fail, and lead to a log spew. Reviewed By: shayne-fletcher Differential Revision: D87926632
Summary:
Currently, when `NetRx` exits, it does not close the write stream gracefully. Since `NetTx` is listening to this write stream for the ack messages, NetTx will see an `close_notify` error, and generate a log like this:
> [-]E1125 06:50:46.476994 518989 fbcode/monarch/hyperactor/src/channel/net/client.rs:988] [net i/o loop{session:metatls:2401:db00:eef0:1120:3520:0:6c09:3cba:44243.17588939158573269181, connected:true, next_seq:2, largest_acked:AckedSeq { seq: 0, timestamp: "2s 805us 589ns" }, outbox:QueueValue::NonEmpty { len: 1, num_bytes_queued: 20, front: QueueEntryValue { seq: 1, since_received: ("817us 855ns",), since_sent: () }, back: QueueEntryValue { seq: 1, since_received: ("821us 911ns",), since_sent: () } }, unacked:QueueValue::Empty}] failed while receiving ack, dest:metatls:2401:db00:eef0:1120:3520:0:6c09:3cba:44243, session_id:17588939158573269181, error:peer closed connection without sending TLS close_notify: https://docs.rs/rustls/latest/rustls/manual/_03_howto/index.html#unexpected-eof
This diff fixes that.
Reviewed By: shayne-fletcher
Differential Revision: D87863524
Summary: When `NetRx` is stopped, we should let its `NetTx` half know as well, so it will exit too and stop reconnecting. Otherwise, those reconnections would all fail, and lead to a log spew. Reviewed By: shayne-fletcher Differential Revision: D87926632
pzhan9
force-pushed
the
export-D87926632
branch
from
4751fa9 to
c3226ac
Compare
|
This pull request has been merged in 7dd0a89. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: When
NetRxis stopped, we should let itsNetTxhalf know as well, so it will exit too and stop reconnecting. Otherwise, those reconnections would all fail, and lead to a log spew.Differential Revision: D87926632