Create hyperactor_named crate #2018
Open
+240
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@thomasywang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D87941210. |
Summary: Pull Request resolved: meta-pytorch#2018 We need to make `hyperactor_named` it's own crate to break a circular dependency because `ndslice` and the upcoming `hyperactor_config` use the `Named` trait but cannot take a dependency on `hyperactor`. This actually solves a workaround we previous had https://fburl.com/code/s51usho8 Differential Revision: D87941210
thomasywang
force-pushed
the
export-D87941210
branch
from
493381b to
fe2a476
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We need to make
hyperactor_namedit's own crate to break a circular dependency becausendsliceand the upcominghyperactor_configuse theNamedtrait but cannot take a dependency onhyperactor.This actually solves a workaround we previous had https://fburl.com/code/s51usho8
Differential Revision: D87941210