Introduce ComponentRunner and move run_component + dryrun_component into it #1166
+321
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto it Summary: **This diff** In diff D86351928 we will be using these for itorchx. As per the [comments](https://www.internalfb.com/diff/D86351928?dst_version_fbid=1529632171491258&transaction_fbid=1290864469465105) 1. We introduce ComponentRunner 2. Move run_component and dryrun_component into it 3. Add warnings.warn() with PendingDeprecationWarning for deprecation of run_component and dryrun_component on the existing Runner. In the future diffs we will slowly move code to use the newer ComponentRunner. Differential Revision: D87680982
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff
Differential Revision: D87680982