Feat: rr support with db backend experiment #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alehander92
added
enhancement
alehander92
force-pushed
the
feat-rr-with-db-backend
branch
6 times, most recently
from
6ac126f to
2d5f276
Compare
alehander92
force-pushed
the
feat-rr-with-db-backend
branch
3 times, most recently
from
c549472 to
67a6ec0
Compare
alehander92
force-pushed
the
feat-rr-with-db-backend
branch
3 times, most recently
from
869c578 to
e758084
Compare
alehander92
force-pushed
the
feat-rr-with-db-backend
branch
3 times, most recently
from
e2bed0a to
f95979e
Compare
alehander92
force-pushed
the
feat-rr-with-db-backend
branch
5 times, most recently
from
a7d97f3 to
69c39ab
Compare
alehander92
force-pushed
the
feat-rr-with-db-backend
branch
from
3fdf10b to
0e5ba6d
Compare
alehander92
force-pushed
the
feat-rr-with-db-backend
branch
from
7ae1593 to
ecacf14
Compare
Auto formatted most of the code
make them a bit more like rust / backend-manager prints, but with location info TODO: maybe don't do it for production builds?
TODO: still some problem with starting it
…make output optional
Co-authored-by: Madman10K <stanv.contact176@gmail.com>
Glory to God!
TODO: bugfixing and finish jumping
…r `Box<Db>` tracepoint tests: `jump_to` with replay to sync stepping; add a note for `Box<Db>` debugged together with Nedy Co-authored-by: pxor <nedislav@gmail.com>
… some rr cases debugged while with Nedy Co-authored-by: pxor <nedislav@gmail.com>
* ) use location.line instead of additional line for first/line line location * ) include end line in registering lines for functions in expr_loader: not sure if fix or incorrect, but applied here * ) fix self.location/ view update location set in flow preloader: probably regressed in my branch; now i hope at least most flow regression cases are fixed for merging * ) accidentally by removing one log of `processed_files` i think a speed slowdown regression in my branch might be fixed: startup for noir spaceship has become slow in my branch, i didn't investigate, but it appears now it's better Praise God for helping me here; as i had some anxiety a bit earlier
alehander92
force-pushed
the
feat-rr-with-db-backend
branch
from
357362e to
e88b8b0
Compare
…urn false instead of true one problem is if we call the same function on the same level and jump there: maybe we can try to load flow and compare rr ticks when jumped to beginning of call even then maybe it's possible to have the same value: not sure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the feature depends on connecting with IPC/socket to a worker, built from some of our closed source code: currently only db-backend is open source, not rr-backend or the new rr worker code
(many things are currently custom there/configured only on my machine, so the build needs to be fixed if we merge something like this)
(more info in our private rr backend repo PR 17 )