Skip to content

allow modifying cookie settings #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

allow modifying cookie settings #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24549b2
allow modifying cookie settings by passing closure to cookie_adjust i…
ovalek Jun 17, 2024
fbee349
use bare CookieBuilder as parameter instead of closure
ovalek Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/token_signer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ use std::marker::PhantomData;
use std::time::Duration;

use actix_web::cookie::Cookie;
use actix_web::cookie::CookieBuilder;
use actix_web::http::header::HeaderValue;
use chrono::TimeDelta;
use derive_builder::Builder;
Expand Down Expand Up @@ -77,6 +78,14 @@ where
*/
#[builder(default = "Duration::from_secs(60)")]
access_token_lifetime: Duration,
/**
Specify cookie parameters like Path, HttpOnly or SameSite.
Example usage `.cookie_builder(Cookie::build("", "").secure(true).path("/"))`

Defaults to (`Cookie::build("", "").secure(true)`).
*/
#[builder(default = "Cookie::build(\"\", \"\").secure(true)")]
cookie_builder: CookieBuilder<'static>,
/**
The name of the future refresh tokens.

Expand Down Expand Up @@ -248,9 +257,10 @@ where
token_lifetime: Duration,
) -> AuthResult<Cookie<'static>> {
let token = self.create_signed_token(claims, token_lifetime)?;
Ok(Cookie::build(cookie_name.to_string(), token)
.secure(true)
.finish())
let mut cookie = self.cookie_builder.clone().finish();
cookie.set_name(cookie_name.to_string());
cookie.set_value(token);
Ok(cookie)
}

/**
Expand Down Expand Up @@ -290,6 +300,7 @@ where
access_token_lifetime: Clone::clone(&self.access_token_lifetime),
refresh_token_name: Clone::clone(&self.refresh_token_name),
refresh_token_lifetime: Clone::clone(&self.refresh_token_lifetime),
cookie_builder: Clone::clone(&self.cookie_builder),
header: Clone::clone(&self.header),
algorithm: Clone::clone(&self.algorithm),
signing_key: Clone::clone(&self.signing_key),
Expand Down