Skip to content

Migrate CSSFontFaceRule and CSSStyleProperties #2238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2025
Merged

Migrate CSSFontFaceRule and CSSStyleProperties #2238

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04234b7
Migrate CSSFontFaceRule and CSSStyleProperties
Bashamega Nov 5, 2025
928d173
-
Bashamega Nov 5, 2025
bbb0603
Update inputfiles/patches/cssom.kdl
saschanaz Nov 6, 2025
1357179
Update src/build/patches.ts
saschanaz Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions inputfiles/addedTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,18 +100,6 @@
]
}
},
"CSSStyleProperties": {
"properties": {
"property": {
"imageOrientation": {
"deprecated": true
},
"wordWrap": {
"deprecated": true
}
}
}
},
"Window": {
"name": "Window",
"methods": {
Expand Down
24 changes: 0 additions & 24 deletions inputfiles/overridingTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3253,30 +3253,6 @@
}
}
},
"CSSFontFaceRule": {
"properties": {
"property": {
"style": {
// CSS Fonts Level 4 now says CSSFontFaceDescriptors but nobody implements it as of 2024-04
// https://github.com/w3c/csswg-drafts/pull/9686
"type": "CSSStyleProperties"
}
}
}
},
"CSSStyleProperties": {
"properties": {
"property": {
"cssFloat": {
"mdnUrl": "https://developer.mozilla.org/docs/Web/API/CSSStyleDeclaration/cssFloat"
},
"webkitLineClamp": {
// The corresponding standardized property is not supported by anyone as of 2024-10.
"deprecated": false
}
}
}
},
"HTMLMediaElement": {
"properties": {
"property": {
Expand Down
7 changes: 7 additions & 0 deletions inputfiles/patches/css-font.kdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,10 @@ enum FontDisplay {
dictionary FontFaceDescriptors {
member display type=FontDisplay
}

interface CSSFontFaceRule {
// CSS Fonts Level 4 now says CSSFontFaceDescriptors
// but nobody implements it as of 2024-04
// https://github.com/w3c/csswg-drafts/pull/9686
property style type=CSSStyleProperties
}
11 changes: 10 additions & 1 deletion inputfiles/patches/cssom.kdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,13 @@ interface CSSStyleDeclaration \
forward=CSSStyleDeclarationBase \
forwardExtends=CSSStyleProperties

interface CSSStyleProperties replaceReference=CSSStyleDeclaration
interface CSSStyleProperties replaceReference=CSSStyleDeclaration {
property imageOrientation deprecated=#true
Copy link
Contributor

@saschanaz saschanaz Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably skip this one. I did this for some reason in 0506730 without a comment (this is why every patch should ideally have a comment 🥹, but presumably it was because of w3c/csswg-drafts@600fd75). But in 2025 all browsers have it and I don't think anyone would unship this.

property wordWrap deprecated=#true

// The corresponding standardized property is not supported by
// anyone as of 2024-10.
property webkitLineClamp deprecated=#false

property cssFloat mdnUrl="https://developer.mozilla.org/docs/Web/API/CSSStyleDeclaration/cssFloat"
Copy link
Contributor

@saschanaz saschanaz Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we lose MDN URL if we skip this one? We have https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleProperties/cssFloat so hopefully not?

}
2 changes: 2 additions & 0 deletions src/build/patches.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,8 @@ function handleProperty(child: Node): Partial<Property> {
...optionalMember("overrideType", "string", child.properties?.overrideType),
...optionalMember("type", "string", child.properties?.type),
...optionalMember("readonly", "boolean", child.properties?.readonly),
...optionalMember("deprecated", "boolean", child.properties?.deprecated),
...optionalMember("mdnUrl", "string", child.properties?.mdnUrl),
};
}

Expand Down