Skip to content

Migrate most html interfaces #2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Migrate most html interfaces #2247

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d3c11c
Migrate most html interfaces
Bashamega Nov 6, 2025
8e90694
update
Bashamega Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 0 additions & 71 deletions inputfiles/addedTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,30 +76,6 @@
]
}
},
"HTMLImageElement": {
"name": "HTMLImageElement",
"properties": {
"property": {
"decoding": {
"name": "decoding",
"overrideType": "\"async\" | \"sync\" | \"auto\""
},
"loading": {
"overrideType": "\"eager\" | \"lazy\""
}
}
}
},
"HTMLMediaElement": {
"events": {
"event": [
{
"name": "encrypted",
"type": "MediaEncryptedEvent"
}
]
}
},
"Window": {
"name": "Window",
"methods": {
Expand Down Expand Up @@ -415,20 +391,6 @@
}
}
},
"HTMLIFrameElement": {
"name": "HTMLIFrameElement",
"properties": {
"property": {
"referrerPolicy": {
"type": "ReferrerPolicy"
},
"loading": {
"name": "loading",
"overrideType": "\"eager\" | \"lazy\""
}
}
}
},
"IDBDatabase": {
"name": "IDBDatabase",
"events": {
Expand Down Expand Up @@ -532,39 +494,6 @@
]
}
},
"HTMLBodyElement": {
"properties": {
"property": {
"onorientationchange": {
"deprecated": true
}
}
}
},
"HTMLInputElement": {
"properties": {
"property": {
"labels": {
"overrideType": "NodeListOf<HTMLLabelElement>"
}
}
}
},
"HTMLLinkElement": {
"properties": {
"property": {
"charset": {
"deprecated": true
},
"rev": {
"deprecated": true
},
"target": {
"deprecated": true
}
}
}
},
"KHR_parallel_shader_compile": {
"overrideExposed": "Window Worker"
},
Expand Down
14 changes: 14 additions & 0 deletions inputfiles/patches/html.kdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,17 @@ interface HTMLTableHeaderCellElement extends=HTMLTableCellElement exposed=Window
interface HTMLDocument extends=Document exposed=Window

interface-mixin MessageEventTarget overrideThis=T typeParameters=T

interface HTMLInputElement {
property labels overrideType="NodeListOf<HTMLLabelElement>"
}

interface HTMLIFrameElement {
property referrerPolicy type=ReferrerPolicy
property loading overrideType="\"eager\" | \"lazy\""
}

interface HTMLImageElement {
property decoding overrideType="\"async\" | \"sync\" | \"auto\""
property loading overrideType="\"eager\" | \"lazy\""
Copy link
Contributor

@saschanaz saschanaz Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to try the alternative string literal: #" (inside this you don't have to escape quotes) "#

Copy link
Contributor Author

@Bashamega Bashamega Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @saschanaz

}