JDK-8313713: Allow CompileCommand flag to specify compilation level #20

JohnTortugo · 2024-07-30T20:32:05Z

By default a compile command applies to all levels
Every compile command can have the level set

specifying comp_level as int is not ideal but is common practice, i'll leve refactor for another RFE

syntax of specifying comp_level on CompileCommand

changing whitebox API to add "comp_level"

validate compilation level range

add tests

src/hotspot/share/compiler/methodMatcher.hpp

JohnTortugo · 2024-08-23T18:33:31Z

src/hotspot/share/compiler/compilationPolicy.cpp

  static bool apply_scaled(const methodHandle& method, CompLevel cur_level, int i, int b, double scale) {
    double threshold_scaling;
-    if (CompilerOracle::has_option_value(method, CompileCommandEnum::CompileThresholdScaling, threshold_scaling)) {
+    if (CompilerOracle::has_option_value(method, CompileCommandEnum::CompileThresholdScaling, cur_level, threshold_scaling)) {


NIT: should this be cur_level or next_level?

JohnTortugo · 2024-08-23T18:43:10Z

src/hotspot/share/oops/methodData.cpp

  double scale = 1.0;
  methodHandle mh(Thread::current(), _method);
-  CompilerOracle::has_option_value(mh, CompileCommandEnum::CompileThresholdScaling, scale);
+  CompilerOracle::has_option_value(mh, CompileCommandEnum::CompileThresholdScaling, CompLevel::CompLevel_any, scale);


should this be any?

src/hotspot/share/runtime/java.cpp

src/hotspot/share/prims/whitebox.cpp

src/hotspot/share/compiler/compilerOracle.cpp

src/hotspot/share/compiler/compilerDirectives.hpp

just the defaults.

7288e8e

JohnTortugo commented Jul 30, 2024

View reviewed changes

src/hotspot/share/compiler/methodMatcher.hpp Outdated Show resolved Hide resolved

JohnTortugo added 4 commits July 30, 2024 13:58

fix directives store used by jvmci.

b4f6a56

Parsing comp_level, some tests are failing.

e458499

fix get_store

1fed6c2

fix parsing of comp_level

0642cdf

JohnTortugo changed the title ~~just the defaults.~~ JDK-8313713: Allow CompileCommand flag to specify compilation level Aug 23, 2024