Skip to content

Now ensuring that enum index is positive #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Now ensuring that enum index is positive #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hotspot/share/services/memoryManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ MemoryManager::MemoryManager(const char* name)
int MemoryManager::add_pool(MemoryPool* pool) {
int index = _num_pools;
assert(index < MemoryManager::max_num_pools, "_num_pools exceeds the max");
Copy link
Member

@swesonga swesonga Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need an assert on the lower bound as well

Copy link
Author

@jmjaffe37 jmjaffe37 Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swesonga what should the lower bound be? Should it be 1? Here is an example line that I could add:
assert(index >= 1, "_num_pools must be at least 1");

if (index < MemoryManager::max_num_pools) {
if (0 <= index && index < MemoryManager::max_num_pools) {
_pools[index] = pool;
_num_pools++;
}
Expand Down
Loading