Skip to content

Conversation

@MrPresent-Han
Copy link
Contributor

@MrPresent-Han MrPresent-Han commented Nov 7, 2025

related: #45418
pr: #45422

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 7, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm

If you have any questions or requests, please contact @zhikunyao.

@sre-ci-robot sre-ci-robot added do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first do-not-merge/need-milestone generate by v2-label-manager labels Nov 7, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[WARNING] No dependent PR reference found

  • Target branch '2.6' requires a PR merged to master first
  • Please add reference in format 'pr: #number'

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@mergify mergify bot added the dco-passed DCO check passed. label Nov 7, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2025

@MrPresent-Han Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #")

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.40%. Comparing base (b33c588) to head (a36f8a2).
⚠️ Report is 6 commits behind head on 2.6.

Files with missing lines Patch % Lines
internal/util/function/rerank/util.go 0.00% 2 Missing ⚠️
internal/proxy/search_reduce_util.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b33c588) and HEAD (a36f8a2). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b33c588) HEAD (a36f8a2)
3 2
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.6   #45419       +/-   ##
===========================================
- Coverage   76.71%   41.40%   -35.31%     
===========================================
  Files        1852     1204      -648     
  Lines      286726   188033    -98693     
===========================================
- Hits       219963    77863   -142100     
- Misses      59436   109838    +50402     
+ Partials     7327      332     -6995     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 83.89% <ø> (ø)
Go 9.62% <0.00%> (-65.07%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/search_reduce_util.go 0.00% <0.00%> (-82.17%) ⬇️
internal/util/function/rerank/util.go 0.00% <0.00%> (-84.27%) ⬇️

... and 1266 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yanliang567 yanliang567 added this to the 2.6.5 milestone Nov 8, 2025
@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 8, 2025
@sre-ci-robot sre-ci-robot removed the do-not-merge/need-milestone generate by v2-label-manager label Nov 8, 2025
@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[FAILED] PR #45422 not merged

Use /refresh-label to update related check and label manually

@yanliang567 yanliang567 modified the milestones: 2.6.5, 2.6.6 Nov 8, 2025
Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, MrPresent-Han

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Contributor

[INFO] PR Label Summary by Default
[FAILED] PR #45422 not merged

Use /refresh-label to update related check and label manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants