This repository was archived by the owner on Aug 31, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
DNM: Placeholder for tracking issue: Inspecjs store #43
Draft
lukemalinowski
wants to merge
9
commits into
master
Choose a base branch
from
inspecjs-store
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6415ba8
Initial switchover
Mitriol 3140b32
Fixed countcard
Mitriol b2ba10f
Fixed Home
Mitriol cdd4ce3
Fixed various getter/setter usages
Mitriol b223d97
Replaced '' with null where appropriate
Mitriol 0d20351
Store function rename parity
Mitriol 17191d0
Loading a file now properly sets showing
Mitriol c35a620
Got treemap working, with fixes to inspecjs
Mitriol c62dc7b
Fixed treemap and datatable
Mitriol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -74,14 +74,12 @@ export default { | |
| }, | ||
| getControls: function () { | ||
| if (isMounted == true) { | ||
| var val = store.getControls(); | ||
| var controls = store.getFilteredNistControls(); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My brain says a function signature like |
||
| let vm = this; | ||
| // Here's the magic to keeping the DataTable in sync. | ||
| // It must be cleared, new rows added, then redrawn! | ||
| vm.dtHandle.clear(); | ||
| val.forEach(function (item) { | ||
| vm.dtHandle.rows.add($(helpers.rowHtml(item))).draw(); | ||
| }); | ||
| controls.forEach(control => vm.dtHandle.rows.add($(helpers.rowHtml(item))).draw()); | ||
|
|
||
| vm.dtHandle.draw(); | ||
| } | ||
|
|
@@ -108,7 +106,7 @@ export default { | |
| }, | ||
| mounted() { | ||
| let vm = this; | ||
| var val = store.getControls(); | ||
| var val = store.getFilteredNistControls(); | ||
| vm.rows = []; | ||
| // You should _probably_ check that this is changed data... but we'll skip that for this example. | ||
|
|
||
|
|
@@ -146,7 +144,8 @@ export default { | |
| } | ||
| else { | ||
| tr.addClass( 'details' ); | ||
| row.child( helpers.detailsPanel( store.getControl(td.innerHTML) ) ).show(); | ||
| var control_uid = tr.attr("unique_id");// | ||
| row.child( helpers.detailsPanel( store.getControlByUniqueID(control_uid) ) ).show(); | ||
|
|
||
| // Add to the 'open' array | ||
| if ( idx === -1 ) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we are able to load multiple 'evaluations' aka profiles - will we need to add both
singularandpluralinterfaces at some point?