This repository was archived by the owner on Apr 20, 2024. It is now read-only.
Make SubmissionsMiddleware ServiceType compliant to add middleware in config as the rest of vapor's available middleware (coding style more than a real improvement) #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
siemensikkema
left a comment
siemensikkema
left a comment
There was a problem hiding this comment.
Much better, thanks 🙂 Just a couple of nitpicks, but otherwise 👍
| public final class SubmissionsMiddleware: Middleware { | ||
| public final class SubmissionsMiddleware: Middleware, ServiceType { | ||
|
|
||
| /// See `ServiceType`. |
Contributor
There was a problem hiding this comment.
Please use spaces here instead of tabs :)
README.md
Outdated
| try services.register(SubmissionsProvider()) | ||
| ``` | ||
|
|
||
| It also include a middleware you have to register in your `MiddlewareConfig` : |
added 4 commits
December 4, 2019 17:04
Allow vapor to find it as a Middleware
Author
|
I took care to correct from your review and improve a little bit the doc. Also add a commit of code (Wasn't sufficient for vapor to make Middleware ServiceType compliant) should really work now. |
|
|
||
| /// See `ServiceType`. | ||
| /// See `ServiceType`. | ||
| public static func makeService(for container: Container) throws -> SubmissionsMiddleware { |
Contributor
There was a problem hiding this comment.
These are tabs, please use spaces 🙂 (in the whole function)
|
|
||
| /// See `Provider` | ||
| public func register(_ services: inout Services) throws { | ||
| services.register(SubmissionsMiddleware.self) |
Contributor
There was a problem hiding this comment.
more tabs that should be spaces 🙂
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-describing (and from #48)