WIP: Finally Use Mffpy for read_raw_egi
#12981
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- more functional - annotate acquisition skips
1. the current EGI reader does this. 2. If we don't do this, then the sensor positions will appear way larger than the head during calls like plot_sensors, plot_components etc. It seems like in the sensorLayout.xml file, that type "2" indicates a head shape point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6937
Maybe also #11380 ?
xref #8038
This is not ready for review(!) But I am using
mffpyfor a project and so I figured I would get this on the board..Maybe a good target date for merge would be just after the MNE 1.9 release, so that devs can work with it for a few months before it is shipped in a stable release.
TODO:
TODO/XXXcommentsmffpy