-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Added a TODO to start implementation of HED support in annotations #13059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VisLab
wants to merge
26
commits into
mne-tools:main
Choose a base branch
from
VisLab:hed-annotations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+326
−2
Open
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
8f0c018
Added a TODO to start implementation of HED support in annotations
VisLab 6f6ccdc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c31e837
add sketch of HEDAnnotations [ci skip]
drammock a593841
Merge branch 'main' into hed-annotations
VisLab b3183d3
rename hed_tags -> hed_strings
drammock 4065433
remove unnecessary TODOs
drammock 5240041
add basic validation
drammock 40311f0
fix err message indentation
drammock 1485356
don't call it foo
drammock 75a4d4f
store HedString objects; use short form for repr
drammock fd7933d
get validation working on __setitem__
drammock 456830a
better repr, better test, use singular form
drammock 6d08c67
Merge branch 'main' into hed-annotations
drammock 233f515
simplify
drammock 5248e9e
make it xrefable
drammock 7c55d59
importorskip
drammock f99ac08
docstring
drammock 1565956
load schema only once
drammock aed0b69
clean up test
drammock 5959c64
fill doc
drammock 30aaade
codecomment
drammock 0c79618
serialization
drammock a2c01fc
use internal version comparator
drammock ef9d563
get append and sort working
drammock 4a5364e
get count working
drammock 308b933
get delete() working
drammock File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could just do:
error_string = self.hed.get_printable_issue_string(issues)Also, do you want to add links to the error descriptions in the HED specification? If so, you could do:
error_string = self.hed.get_printable_issue_string(issues, add_link=True)Are there setting in MNE for just reporting errors and not warnings?