Skip to content

fix: ensure playwright e2e tests pass #4365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
Merged

fix: ensure playwright e2e tests pass #4365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ed-api/dynamic-remotes-synchronous-imports/e2e/checkDynamicRemotesSynchImportApps.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ async function waitForDynamicImport(page: Page, timeout: number = 5000) {

async function checkDateFormat(page: Page) {
// Check for moment.js date display - just look for the Live Time text which indicates moment.js is working
const dateElement = page.locator('text=Live Time (via shared moment.js):');
const dateElement = page.locator('text=Live Time (via shared moment.js):').first();
await dateElement.waitFor({ timeout: 5000 });
}

Expand Down
4 changes: 2 additions & 2 deletions advanced-api/dynamic-remotes-synchronous-imports/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
"build": "pnpm --filter dynamic-remotes-synchronous-imports_app* --parallel build",
"serve": "pnpm --filter dynamic-remotes-synchronous-imports_app* --parallel serve",
"clean": "pnpm --filter dynamic-remotes-synchronous-imports_app* --parallel clean",
"e2e:ci": "npx playwright test",
"legacy:e2e:ci": "npx playwright test"
"e2e:ci": "pnpm exec playwright install --with-deps && pnpm exec playwright test",
"legacy:e2e:ci": "pnpm exec playwright install --with-deps && pnpm exec playwright test"
},
"devDependencies": {
"@playwright/test": "^1.54.2",
Expand Down
Loading