-
Notifications
You must be signed in to change notification settings - Fork 15
feat!: upgrade support to node 22 and 24 #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 49 commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
8cfa9d1
chore: Upgrade support to node 22 and 24
kmruiz 687c75b
chore: use devtools toolchain on linux and upgrade macos deps
kmruiz 1062b93
chore: change display name, it's misleading
kmruiz 8254b4c
chore: add brotli as a dependency when compiling the test
kmruiz a695c62
chore: reuse devtools toolchain in Linux
kmruiz 9649c4c
chore: fix typo
kmruiz 6bfb4c5
chore: simplify by using a stable folder after installation
kmruiz 5771991
chore: Remove unsupported flags for r/o heaps
kmruiz 6a13147
chore: fix check in OSX
kmruiz d46ce11
chore: use 22 until we have 24
kmruiz 059accd
chore: create parent node folder, necessary for the symlink
kmruiz 0c32538
chore: upgrade node-gyp to the latest
kmruiz f3fbc0a
chore: upgrade test template to node 24 and std=c++20
kmruiz eb955bd
chore: remove assert(CanUseCustomSnapshotPerIsolate)
kmruiz 59714b3
chore: forgot to remove the test skip
kmruiz 3703751
chore: unregister isolate *after* disposing isolate
addaleax 8c9aa72
feat!: remove support code for older Node.js versions
addaleax 0193614
chore: add evergreen task for testing dchecks
addaleax 58aa93c
chore: use ubuntu instead of amazon for dcheck runs
addaleax 62befca
fixup: use fixed version of weak-napi
addaleax c97bb8e
chore: upgrade to vs2022 to test
kmruiz 9a90bfc
chore: upgrade host so it has msvc 2022
kmruiz 0b369dd
chore: typo in the evergreen distro
kmruiz b18ff4d
chore(ci): use llvm from homebrew on evergreen macOS
addaleax 80a6c5b
chore: Use python3.11 in windows host
kmruiz 5f69428
chore: make sure python 3.11 is used everywhere, also when compiling
kmruiz 6a202b4
chore: make sure that the hash is updated so it uses the proper pytho…
kmruiz 4ce4d23
chore: also setup python and python3 env vars for node-gyp
kmruiz 0d45733
chore: use NODE_GYP_FORCE_PYTHON
kmruiz 729269d
chore: use windows path and simplify
kmruiz 8757467
chore: normalise to spaces
kmruiz b27af71
chore: untabify, use spaces always
kmruiz a03f2fa
chore: setup VC environment and upgrade command args for vcbuild
kmruiz e51e0b3
chore: stub APPDATA env var
kmruiz c5e2374
chore: adapt it to use CMD properly
kmruiz 6d8d132
chore: fix order of parameters
kmruiz 96e56d2
chore: we still need to projgen
kmruiz 3ce25c4
chore: do not use $TEMP because files there can be deleted
kmruiz 5ae7b1c
chore: typo :(
kmruiz 8190e66
chore: upgrade to node 24 (the LTS) and increase timeout
kmruiz dc20888
chore: use the same base in all machines (22.17.0)
kmruiz 71190c7
chore: setup windows tests also in GHA for faster feedback
kmruiz 1d3b039
chore: remove unused deps and remove setup of MSVC DevTools
kmruiz 6c2f8ec
chore: support all architecture flags
kmruiz 20b8394
chore: increase timeout (default is 6h, builds can take more time)
kmruiz 5c60c29
chore: fix linter issues
kmruiz 2512e1a
chore: use DEBUG, as it's faster, and it's good enough for a safety c…
kmruiz 484525b
chore: split each test in it's own job to avoid disk space issues
kmruiz 600635a
chore: we can't use cache: npm because we don't have a package-lock
kmruiz 60aacaf
chore: delete precompiled headers on windows and node24>
kmruiz afb5e0f
chore: Remove test, now the behaviour is tested by the compiler
kmruiz 33cba5b
chore: use rimraf instead of custom code, it should be easier to main…
kmruiz 5e2b32b
chore: Generate the GHA workflow from a template
kmruiz 14075a2
chore: Fix linter issues (spacing and unused deps)
kmruiz 9be677b
chore: use -f instead of -g for the test runner
kmruiz fda3cca
chore: Remove pch files from compilation artifacts in tmp directory
kmruiz 4f31b14
chore: Print the folder where we are deleting pchs from
kmruiz a5954aa
chore: attempt to upgrade rimraf to latest version
kmruiz a199a1c
chore: Use follow: true, so it follows symlinks and junctions
kmruiz 9a03778
chore: resolve the realpath of nodeSourcePath before deleting pchs
kmruiz 5b9d8c2
chore: Remove all directories that can contain compilation outputs
kmruiz 2a6fd18
chore: try to delete the whole out directory for a fresh compilation
kmruiz a8b3e22
chore: Simplify naming, we now wipe out the whole out directory
kmruiz b947e75
chore: ensure that any output directory is cleaned up before compiling
kmruiz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| CALL "C:\Program Files\Microsoft Visual Studio\2022\Professional\VC\Auxiliary\Build\vcvars64.bat" | ||
| REM APPDATA is empty in CMD, and npm requires it to be a valid path | ||
| SET APPDATA="npm-cache" | ||
|
|
||
| CALL npm run build | ||
| CALL npm run test-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,16 @@ | ||
| if [[ "$OS" == "Windows_NT" ]]; then | ||
| export PATH="$PWD/.deps/node/bin:$PATH" | ||
| export APPDATA="npm-cache" | ||
| export PATH="$PWD/.deps/node/bin:$PATH" | ||
| else | ||
| export NVM_DIR="$PWD/.deps/nvm" | ||
| [ -s "$NVM_DIR/nvm.sh" ] && source "$NVM_DIR/nvm.sh" | ||
| # so we use the devtools binaries first (for gcc/g++) | ||
| export PATH="/opt/devtools/bin:$PATH" | ||
|
|
||
| if [ "$(uname -s)" == "Darwin" ] ; then # in OSX use nvm | ||
| export NVM_DIR="$PWD/.deps/nvm" | ||
| [ -s "$NVM_DIR/nvm.sh" ] && source "$NVM_DIR/nvm.sh" | ||
| else # In Linux, use .deps/node/bin because it was set up with symlink to an existing node in the toolchain | ||
| export PATH="$PWD/.deps/node/bin:$PATH" | ||
| fi | ||
| fi | ||
|
|
||
| echo "updated PATH=$PATH" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.