Skip to content

Conversation

@baileympearson
Copy link
Contributor

Description

Summary of Changes

This PR fixes the release action.

Some past context: This package depends on the npm package whatwg-url. Version 13.x of of whatwg-url supports Node 16, but prints deprecation warnings when used. Version 14.x does not support Node16 but does not used deprecated code. We support both, and let npm choose which to install based on the user's Node version. But this means that we can't have a package-lock file if we want our CI to install the correct version of whatwg-url in our CI, so we've removed the package-lock from this repo. Once we are Node20+, we can add the package-lock.json back and update whatwg-url to 15.x, resolving this issue permanently. This PR is a workaround so we can release one last version of mongodb-connection-string-url for devtools before the next major version.

Notes for Reviewers

What is the motivation for this change?

Release Highlight

Release notes highlight

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson requested a review from a team as a code owner September 15, 2025 10:55
@durran durran merged commit d5dd934 into main Sep 15, 2025
30 checks passed
@durran durran deleted the no-story-fix-release-action branch September 15, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants