Skip to content

chore: retry the whole test with fixtures in case of error #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2025
Merged

chore: retry the whole test with fixtures in case of error #684

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21c2a02
chore: retry the whole test with fixtures in case of error
kmruiz Oct 24, 2025
901d837
Merge branch 'main' into fix/oidc-reliability
kmruiz Oct 24, 2025
85a6865
chore: increase timeout for slow tests and extract retries to a constant
kmruiz Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/integration/common/connectionManager.oidc.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,13 +107,15 @@
(integration) => {
function oidcIt(name: string, cb: Parameters<OidcIt>[1]): void {
/* eslint-disable vitest/expect-expect */
it(name, { timeout: DEFAULT_TIMEOUT }, async (context) => {
it(name, { timeout: DEFAULT_TIMEOUT, retry: 5 }, async (context) => {

Check failure on line 110 in tests/integration/common/connectionManager.oidc.test.ts

View workflow job for this annotation

GitHub Actions / Run MongoDB tests (ubuntu-latest)

tests/integration/common/connectionManager.oidc.test.ts > ConnectionManager OIDC Tests > 8.0.12 Enterprise :: auth-flow;nonce=false > can connect with the expected user 

Error: Test timed out in 30000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
 ❯ it tests/integration/common/connectionManager.oidc.test.ts:110:21
 ❯ tests/integration/common/connectionManager.oidc.test.ts:165:13
 ❯ getUserConfig tests/integration/common/connectionManager.oidc.test.ts:140:17
 ❯ tests/integration/tools/mongodb/mongodbHelpers.ts:109:9
Copy link
Collaborator

@gagik gagik Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there some wait time for this? would it make sense to introduce some wait on retries?

Copy link
Collaborator Author

@kmruiz kmruiz Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vitest doesn't support wait time :( https://vitest.dev/api/#test-api-reference

context.skip(
await isCommunityServer(integration),
"OIDC is not supported in MongoDB Community"
);
context.skip(
semver.satisfies(await getServerVersion(integration), "< 7", { includePrerelease: true }),
semver.satisfies(await getServerVersion(integration), "< 7", {
includePrerelease: true,
}),
"OIDC is only supported on MongoDB newer than 7.0"
);

Expand Down
Loading