chore: update mongosh #1130
Merged
chore: update mongosh #1130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the mongosh service provider. Among other things, this allows us to no longer be broken with mongosh VSCode tests
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates mongosh dependencies to newer versions and removes the boolean parameter from service provider close() method calls to align with the updated API. This change ensures compatibility with the latest mongosh versions and fixes VSCode test issues.
- Updated mongosh packages to version 3.23.0 and related dependencies
- Removed boolean parameter from
close()method calls across the codebase - Updated service provider core dependency to version 3.6.0
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated mongosh package versions to 3.23.0 and service-provider-core to 3.6.0 |
| src/mcp/mcpConnectionManager.ts | Removed boolean parameter from provider close() call |
| src/language/worker.ts | Removed boolean parameter from serviceProvider close() call |
| src/language/mongoDBService.ts | Removed boolean parameter from serviceProvider close() call |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gagik
added
the
no-title-validation
addaleax
reviewed
Sep 19, 2025
package-lock.json
Outdated
| "version": "1.7.2", | ||
| "resolved": "https://registry.npmjs.org/mongodb-build-info/-/mongodb-build-info-1.7.2.tgz", | ||
| "integrity": "sha512-eoLFZvCIjcwijYJdxvYupj1c+55VAVm0o4gBJjrcDxxmmpm+bC4Ix9ayZbyhQdVXDZAGDi03NA0GghXjBVXnxg==", | ||
| "node_modules/mongodb-mcp-server/node_modules/@mongosh/service-provider-node-driver": { |
Contributor
There was a problem hiding this comment.
^ This is probably the reason for the test failure – you basically always want @mongosh/service-provider-node-driver to be hoisted without duplicates
addaleax
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the mongosh service provider. Among other things, this allows us to no longer be broken with mongosh VSCode tests
Blocked by mongodb-js/mongodb-mcp-server#574
See also: mongodb-js/mongosh#2538