Skip to content

Conversation

@ajcvickers
Copy link
Contributor

- Ensure index definitions are valid per https://www.mongodb.com/docs/atlas/atlas-search/index-definitions/
- Use unique index name for each variation
Copilot AI review requested due to automatic review settings November 6, 2025 13:42
@ajcvickers ajcvickers requested a review from a team as a code owner November 6, 2025 13:42
@ajcvickers ajcvickers requested a review from papafe November 6, 2025 13:42
@ajcvickers ajcvickers added the chore Non–user-facing code changes (tests, build scripts, etc.). label Nov 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves test maintainability for Atlas Search Index tests by refactoring index name generation and addressing test isolation issues. The changes ensure that tests with different parameters (async vs sync, with/without fields) create uniquely named indexes to avoid conflicts.

  • Introduced a helper method CreateIndexName to generate unique index names based on test parameters
  • Updated index definitions to use more realistic field configurations
  • Refactored test methods to use the new helper and apply correct index definitions based on test parameters

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codeowners-service-app
Copy link

Assigned jordan-smith721 for team dbx-csharp-dotnet because papafe is out of office.

@papafe
Copy link
Contributor

papafe commented Nov 10, 2025

Assigned jordan-smith721 for team dbx-csharp-dotnet because papafe is out of office.

I'm not out of office anymore by the way 😁

papafe
papafe previously approved these changes Nov 10, 2025
Copy link
Contributor

@papafe papafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

There is just an extra line

…ts.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ajcvickers
Copy link
Contributor Author

@papafe Thanks! Fixed that line.

@ajcvickers
Copy link
Contributor Author

@papafe Can you approve again, since including the Copilot commit reset the Approved status?

@ajcvickers ajcvickers merged commit c37bad3 into mongodb:main Nov 10, 2025
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Non–user-facing code changes (tests, build scripts, etc.).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants