PYTHON-5537 Update typing dependencies #2524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahStapp
requested changes
Sep 10, 2025
| assert out["foo"] # type:ignore[typeddict-item] | ||
| # pyright gives reportTypedDictNotRequiredAccess for the following: | ||
| assert out["_id"] # type:ignore | ||
| assert out["_id"] # type:ignore[unused-ignore] |
Contributor
There was a problem hiding this comment.
What's the purpose of this? # type:ignore[unused-ignore] sounds like an oxymoron.
Member
Author
There was a problem hiding this comment.
mypy wants to ignore it, pyright does not. 💀
NoahStapp
approved these changes
Sep 10, 2025
aclark4life
pushed a commit
to aclark4life/mongo-python-driver
that referenced
this pull request
Sep 11, 2025
Member
Author
|
drivers-pr-bot please backport to v4.15 |
mongodb-dbx-release-bot bot
pushed a commit
that referenced
this pull request
Sep 16, 2025
(cherry picked from commit 527cbdd)
blink1073
added a commit
that referenced
this pull request
Sep 16, 2025
Co-authored-by: Steven Silvester <steven.silvester@ieee.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account for the
--strict-bytesparameter added in mypy 1.15, which is enabled by our use ofstrict=truewithout explicitly opting out of the behavior.The only runtime behavior I made was having
PyMongoKMSProtocol.read()return bytes, which simplified the code and matched the behavior ofPyMongoProtocol.read().