fix(NODE-7290): deserialize error with promoteValues #4783
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
This fix ensures that
MongoServerErroris initialized with values that've been deserialized withpromoteValueson.Notes for Reviewers
Let me know what's a good place to add a test to.
What is the motivation for this change?
This came up in a help ticket from our customer: https://jira.mongodb.org/browse/HELP-83883. The problem was caused by the code sometimes being an

Int32instead of a primitive value. This goes againstMongoErrortype definition:And it lead to this check failing to catch the
391as intended:node-mongodb-native/src/sdam/server.ts
Line 359 in 2512137
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript