fix(NODE-7229): remove duplicate server selection when auto-connecting #4787
+116
−1,119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
commented
Nov 7, 2025
Comment on lines
+208
to
+213
| if ( | ||
| session?.snapshotEnabled && | ||
| maxWireVersion(topology) < MIN_SUPPORTED_SNAPSHOT_READS_WIRE_VERSION | ||
| ) { | ||
| throw new MongoCompatibilityError('Snapshot reads require MongoDB 5.0 or later'); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
When this check was done by ServerCapabilities it was written as
this.maxWireVersion >= 13;Which is the opposite right? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Move the server selection in connect into the skipPing section which will make it not run for operations that are causing the MongoClient to connect for the first time.
Notes for Reviewers
What is the motivation for this change?
Remove redundancy in the auto-connect path
Release Highlight
Remove extra server selection in auto-connect
When running an operation (ex.
insertOne) on a new MongoClient that hasn't been connected yet the first server selection performed will now be for that operation.Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript