Skip to content

DRIVERS-1934: withTransaction API retries too frequently #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 24, 2025
Merged

DRIVERS-1934: withTransaction API retries too frequently #1851

merged 14 commits into from
Nov 24, 2025
+120 −11

Conversation

@sleepyStick
Copy link
Contributor

@sleepyStick sleepyStick commented Oct 17, 2025 •
edited
Loading

Please complete the following before merging:

  • Is the relevant DRIVERS ticket in the PR title?
  • Update changelog.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, and sharded
    clusters).

python implementation: mongodb/mongo-python-driver#2600

sleepyStick
sleepyStick commented Oct 17, 2025
View reviewed changes
source/transactions-convenient-api/transactions-convenient-api.md Outdated
callbacks.

A previous design had no limits for retrying commits or entire transactions. The callback is always able indicate that
A previous design had no limits for retrying commits or entire transactions. The callback is always able to indicate that
Copy link
Contributor Author

@sleepyStick sleepyStick Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I read it wrong, or maybe its a typo? Not sure.

source/transactions-convenient-api/transactions-convenient-api.md Outdated
[abortTransaction](../transactions/transactions.md#aborttransaction) on the session.
2. If the callback's error includes a "TransientTransactionError" label and the elapsed time of `withTransaction` is
less than 120 seconds, jump back to step two.
less than 120 seconds, sleep for `jitter * min(BACKOFF_INITIAL * (1.25**retry), BACKOFF_MAX)` where:
Copy link
Contributor Author

@sleepyStick sleepyStick Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know python uses ** as the exponential operator. I don't believe that is a standard across other programming languages. Is it clear that its exponent? Is there a different preferred symbol for exponent? (I know math commonly uses ^ but it typically also means bitwise XOR in code so I felt like that could be confusing.)

Copy link
Contributor

@baileympearson baileympearson Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

** seems fine to me, but I might also be biased because that's what Node does 🙂. But I don't think people will have trouble understanding what this means.

ShaneHarvey
ShaneHarvey requested changes Oct 20, 2025
View reviewed changes
sleepyStick
sleepyStick commented Oct 23, 2025
View reviewed changes
ShaneHarvey
ShaneHarvey requested changes Oct 24, 2025
View reviewed changes
baileympearson
baileympearson requested changes Oct 27, 2025
View reviewed changes
@sleepyStick sleepyStick marked this pull request as ready for review November 12, 2025 21:44
@sleepyStick sleepyStick requested a review from a team as a code owner November 12, 2025 21:44
@sleepyStick sleepyStick requested review from alcaeus and removed request for a team November 12, 2025 21:44
@alcaeus alcaeus requested review from durran and removed request for alcaeus November 13, 2025 08:18
ShaneHarvey
ShaneHarvey reviewed Nov 13, 2025
View reviewed changes
ShaneHarvey
ShaneHarvey reviewed Nov 13, 2025
View reviewed changes
ShaneHarvey
ShaneHarvey requested changes Nov 18, 2025
View reviewed changes
baileympearson
baileympearson requested changes Nov 18, 2025
View reviewed changes
baileympearson
baileympearson previously requested changes Nov 19, 2025
View reviewed changes
ShaneHarvey
ShaneHarvey approved these changes Nov 21, 2025
View reviewed changes
Copy link
Member

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

comandeo-mongo
comandeo-mongo approved these changes Nov 24, 2025
View reviewed changes
Copy link
Contributor

@comandeo-mongo comandeo-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe we can add a link to the reference implementation to PRs description.

@sleepyStick
Copy link
Contributor Author

sleepyStick commented Nov 24, 2025

LGTM! Maybe we can add a link to the reference implementation to PRs description.

Good suggestion! I added a link to the python PR in the PR description now!

@sleepyStick sleepyStick merged commit 135add4 into master Nov 24, 2025
6 checks passed
@sleepyStick sleepyStick deleted the DRIVERS-1934 branch November 24, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@durran durran durran approved these changes

@ShaneHarvey ShaneHarvey ShaneHarvey approved these changes

@baileympearson baileympearson baileympearson approved these changes

@comandeo-mongo comandeo-mongo comandeo-mongo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sleepyStick @durran @ShaneHarvey @baileympearson @comandeo-mongo