Skip to content

Fixed memory copy error of virtual table under multiple inheritance #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fixed memory copy error of virtual table under multiple inheritance #1695

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1e502ff
Fixed memory copy error of virtual table under multiple inheritance
Nov 18, 2022
e97322e
Merge branch 'mono:main' into main
hxbb00 Nov 23, 2022
11b6445
Merge branch 'mono:main' into main
hxbb00 Dec 12, 2022
3665afa
Merge branch 'mono:main' into main
hxbb00 Feb 9, 2023
4fc7801
Merge branch 'mono:main' into main
hxbb00 Feb 21, 2023
9e3c1dc
Merge branch 'mono:main' into main
hxbb00 Apr 7, 2023
2bfa7b7
Merge branch 'mono:main' into main
hxbb00 Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Runtime/VTables.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public T GetMethodDelegate<T>(short table, int slot, short specialiation = 0) wh
public unsafe static IntPtr* CloneTable(List<SafeUnmanagedMemoryHandle> cache, IntPtr instance, int offset, int size, int offsetRTTI)
{
var sizeInBytes = (size + offsetRTTI) * sizeof(IntPtr);
var src = (((*(IntPtr*)instance) + offset) - offsetRTTI * sizeof(IntPtr)).ToPointer();
var src = (*(IntPtr**)(instance + offset) - offsetRTTI);
var entries = (IntPtr*)Marshal.AllocHGlobal(sizeInBytes);

Buffer.MemoryCopy(src, entries, sizeInBytes, sizeInBytes);
Expand Down