Better support for enums. #53
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix proposed in #51 for issue #50 will remove SQL error, but also make enum fields always a
$faker->wordin generated factories.PostgreSQL implementation of enum does not store allowed values in type definition, instead there is a field constraint.
I came up with solution that supports both MySQL and PostgreSQL.
Right now it should work even without a custom enum type for Doctrine.
I tested it with PostgreSQL and this migration:
Generated factory:
Changes that were made:
enumValuesfunction to check connection driver name.enumValuesis not static anymore (I honestly don't know why it was).setPropertyis returned instantly if matches any of$fakeableNames, so it won't make a DB call for enum.$faker->randomElementif any enum values are present (only if it's an actual enum field in database).