Skip to content

DenoiseNode: Retain unprocessed input values. #28882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024
Merged

DenoiseNode: Retain unprocessed input values. #28882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions src/nodes/display/DenoiseNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,19 @@ class DenoiseNode extends TempNode {

} );

const denoise = tslFn( () => {
const denoise = tslFn( ( [ uvNode ] ) => {

const depth = sampleDepth( uvNode );
const viewNormal = sampleNormal( uvNode ).rgb.normalize();

depth.greaterThanEqual( 1.0 ).discard();
dot( viewNormal, viewNormal ).equal( 0.0 ).discard();

const texel = sampleTexture( uvNode );

If( depth.greaterThanEqual( 1.0 ).or( dot( viewNormal, viewNormal ).equal( 0.0 ) ), () => {

return texel;

} );

const center = vec3( texel.rgb );

const viewPosition = getViewPosition( uvNode, depth );
Expand Down Expand Up @@ -132,10 +136,21 @@ class DenoiseNode extends TempNode {

return vec4( denoised, 1.0 );

} ).setLayout( {
name: 'denoise',
type: 'vec4',
inputs: [
{ name: 'uv', type: 'vec2' }
]
} );

const output = tslFn( () => {

return denoise( uvNode );

} );

const outputNode = denoise();
const outputNode = output();

return outputNode;

Expand Down