Skip to content

SSGINode: Improve GI Blending #31882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 11, 2025
Merged

SSGINode: Improve GI Blending #31882

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2814373
Improve GI Blending
zalo Sep 11, 2025
71b43f5
Also fix the TRAA Toggle
zalo Sep 11, 2025
e83617c
Add missing semi-colon
zalo Sep 11, 2025
0573e4f
Fix Radius Changing with Step Count
zalo Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions examples/webgpu_postprocessing_ssgi.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<script type="module">

import * as THREE from 'three/webgpu';
import { pass, mrt, output, normalView, velocity, add, vec3, vec4 } from 'three/tsl';
import { pass, mrt, output, normalView, diffuseColor, velocity, add, vec3, vec4 } from 'three/tsl';
import { ssgi } from 'three/addons/tsl/display/SSGINode.js';
import { traa } from 'three/addons/tsl/display/TRAANode.js';

Expand Down Expand Up @@ -78,11 +78,13 @@
const scenePass = pass( scene, camera );
scenePass.setMRT( mrt( {
output: output,
diffuseColor: diffuseColor,
normal: normalView,
velocity: velocity
} ) );

const scenePassColor = scenePass.getTextureNode( 'output' );
const scenePassDiffuse = scenePass.getTextureNode( 'diffuseColor' );
Copy link
Collaborator

@Mugen87 Mugen87 Sep 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding this below the getTextureNode() block? This will change the format from RGBA16 to RGBA8 saving half of the memory and bandwidth. For modulating the GI, this precision should be sufficient.

const diffuseTexture = scenePass.getTexture( 'diffuseColor' );
diffuseTexture.type = THREE.UnsignedByteType;

const scenePassDepth = scenePass.getTextureNode( 'depth' );
const scenePassNormal = scenePass.getTextureNode( 'normal' );
const scenePassVelocity = scenePass.getTextureNode( 'velocity' );
Expand All @@ -98,7 +100,7 @@
const gi = giPass.rgb;
const ao = giPass.a;

const compositePass = vec4( add( scenePassColor.rgb, gi ).mul( ao ), scenePassColor.a );
const compositePass = vec4( scenePassColor.rgb.mul( ao ).add( scenePassDiffuse.rgb.mul( gi ) ), scenePassColor.a );

// traa

Expand Down
Loading