Skip to content

Conversation

@querielo
Copy link
Contributor

@querielo querielo commented Nov 6, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 6, 2025 22:15
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 356.24
86.47
356.24
86.47
+0 B
+0 B
WebGPU 610.57
171.28
610.57
171.28
+0 B
+0 B
WebGPU Nodes 609.18
171.02
609.18
171.02
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 487.87
121.22
487.87
121.22
+0 B
+0 B
WebGPU 679.35
186.51
679.35
186.51
+0 B
+0 B
WebGPU Nodes 621.07
169.69
621.07
169.69
+0 B
+0 B

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the JSDoc return type annotation for the compileAsync method to accurately reflect its implementation.

  • Updated the return type documentation from Promise<Array|undefined> to Promise<void> to match the actual behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Mugen87 Mugen87 added this to the r182 milestone Nov 7, 2025
@Mugen87 Mugen87 merged commit 5a8d296 into mrdoob:dev Nov 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants