SSRNode: Ensure boolean value for isPerspectiveCamera uniform. #32218
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: N/A
Description
The SSR node breaks with the following error when used with
OrthographicCamera. This is because the current code resolves tothis._isPerspectiveCamera = uniform( undefined );asisPerspectiveCamerais undefined onOrthographicCamera.Error
Fixed by ensuring the
_isPerspectiveCamerauniform is a boolean.Broken example on r181:
https://codesandbox.io/p/devbox/cranky-framework-zrtfz3?workspaceId=ws_5NvLnrKyk5Nd2YftNHw3Fy