fix(reranker): support omitting top_n #7199
Open
+34
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Khludnev <mkhl@apache.org>
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Mikhail Khludnev <mkhl@apache.org>
This was referenced Nov 8, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue introduced in #7025
Notes for Reviewers
#7025 introduced handling result cropping by
top_n. However, I believe the most users just omittop_n, just because don't bother to countlen(documents). So, I'm afraid releasing #7025 causes a trouble for many users. @mudler, beg your pardon.This PR let users to omit
top_nor sendtop_n=0meaning all docs.One thing about tests, since tey bring up the backend every time, isn't it worth to loop three alt requests in the single test method?
Signed commits