Fix flaky tests JoinMapperNewSyntaxTest
#982
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Similar to #981.
Replaced
containsExactly(...)withcontainsOnly(...)to avoid assuming deterministic field order in rows/Maps.Why
The test failed intermittently because Map iteration order is not guaranteed. NonDex exposed this by randomizing iteration order.
How to reproduce
Run the test repeatedly with NonDex:
You will see failures like:
How tested
Verified with the same NonDex runs; no further order-related failures occurred.
Tests fixed
examples.kotlin.mybatis3.joins.JoinMapperNewSyntaxTest.testFullJoinWithoutAliasesexamples.kotlin.mybatis3.joins.JoinMapperNewSyntaxTest.testLeftJoinWithAliasesexamples.kotlin.mybatis3.joins.JoinMapperNewSyntaxTest.testLeftJoinWithoutAliasesexamples.kotlin.mybatis3.joins.JoinMapperNewSyntaxTest.testLeftJoinWithSubQueryexamples.kotlin.mybatis3.joins.JoinMapperNewSyntaxTest.testRightJoinWithAliasesexamples.kotlin.mybatis3.joins.JoinMapperNewSyntaxTest.testRightJoinWithoutAliasesexamples.kotlin.mybatis3.joins.JoinMapperNewSyntaxTest.testRightJoinWithSubQueryexamples.kotlin.mybatis3.joins.JoinMapperNewSyntaxTest.testSelfexamples.kotlin.mybatis3.joins.JoinMapperNewSyntaxTest.testSelfWithNewAliasexamples.kotlin.mybatis3.joins.JoinMapperNewSyntaxTest.testSelfWithNewAliasAndOverride