Feature/new handshake #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per ADR-30. Main logic is contained in the BoltHandShaker class. There have also been updates to the BoltProtocolFactory and BoltProtocolVersion to support identifying versions. A new 'type' VarLong has been added to the util folder, this implements VarInt logic the description of which can be found in the ADR and all good search engines.
…many verisons. Previously it was erroniously reading a full version thinking that that represented the lower bound. Added support for testkits Feature:Bolt:HandshakeManifestV1 Fixed a bug where the encoded response was being sent with an incorrect length.
…en out are logged. Removed member variables from the class as it is used as a singleton and state was being carried between multiple handshake negotiations. Means more variables being passed around but I don't want to reengineer at this point. Updated tests to accomodate the change to member variables.
Contributor
Author
RichardIrons-neo4j
approved these changes
Feb 26, 2025
…areTo Changed type in VarLong.AddSegment to byte.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the new manifest style handshake as per the ADR - 30 (https://github.com/neo-technology/drivers-adr/blob/main/adrs/030-handshake-manifest-v1.md)