Skip to content

update rule for P2P + FabricPeering: true #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

update rule for P2P + FabricPeering: true #669

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f7e329
update rule for P2P + FabricPeering: true
ccoueffe Nov 12, 2025
d5c2e76
fix pep8
ccoueffe Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions roles/validate/files/rules/ibgp_vxlan/208_manual_ipaddress_allocation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,12 @@ def validate_fabric_links(cls, data_model, vpc_peers_list):
for peer in vpc_peers:
peer1 = f"{peer.get('peer1')}-{peer.get('peer2')}"
peer2 = f"{peer.get('peer2')}-{peer.get('peer1')}"
if not (peer1 in fabric_links_list or peer2 in fabric_links_list):
cls.results.append(
f"Fabric link between '{peer1}' and '{peer2}' is missing."
)
fabric_peering = peer.get("fabric_peering", False)
if fabric_peering is False:
if not (peer1 in fabric_links_list or peer2 in fabric_links_list):
cls.results.append(
f"Fabric link between '{peer1}' and '{peer2}' is missing."
)

@classmethod
def check_interface_with_ipv4(cls, interfaces, loopback_name):
Expand Down