feat: Support HTTP schemes #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicahParks
commented
Aug 8, 2025
MicahParks
requested review from
jajeffries,
leoparente,
ltucker and
mfiedorowicz
as code owners
jajeffries
approved these changes
Aug 8, 2025
Contributor
jajeffries
left a comment
jajeffries
left a comment
There was a problem hiding this comment.
LGTM - I'm not sure if we class this as a breaking change due to the port change, but I think in practice people will almost always be specifying a port so it should be ok
mfiedorowicz
approved these changes
Aug 11, 2025
Co-authored-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Diode SDK to support both gRPC and HTTP(S) connection schemes, improving flexibility for users. The main changes clarify usage in the documentation and enhance the connection parsing logic to handle more schemes and default ports.
Documentation improvements:
README.mdto explain thattargetcan usegrpc://,grpcs://,http://, orhttps://schemes, with examples for both insecure and secure connections.Connection parsing enhancements:
parse_targetinclient.pyto accepthttpandhttpsschemes in addition togrpcandgrpcs, and updated the error message accordingly.parse_targetto use:80forgrpcandhttp, and:443forgrpcsandhttps.grpcsandhttpsschemes.