[pull] master from kubernetes:master #1065
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI: delete prow images not needed anymore
…709c2fe Kicbase/ISO: Update docker from 28.4.0 to 28.5.1
CI: Update cron jobs to run on Saturday 1 AM instead of Monday
Remove the docker-machine-driver-kvm2 wrapper and use the kvm driver as internal driver. To avoid dependency on libvirt shared library on Linux, we build now with the libvirt_dlopen build tag. This is used only linux to avoid linking with libvirt shared library. This is not documnted but can be found in the source. https://gitlab.com/libvirt/libvirt-go-module/-/blob/f7cdeba9979dd248582901d2aaf7ab1f2d27cbe0/domain.go#L30 With this we don't need libvirt devel libraries during build, and in runtime we will fail if libvirt shared library is not installed. With this change minikube can not be built for linux !amd64 since building libvirt go binding requires CGO, and it does not work by changing GOARCH.
The build fails on linux/arm64 because libvirt.org/go/libvirt is using CGO, and cross compiling CGO requires a C cross compiler. Setting GOARCH=arm64 is not enough. The issue is tracked in #19959. Previously we built the kvm driver also on arm64 as part of the docker-machine-driver-kvm2 executable, but the build was skipped on arm64. Now that we build the driver as part of minikube, we cannot skip the entire build. Change the build tag so the libvirt bits are built only on amd64. To make this possible, the generic linux bits needed by the registry moved to pkg/drivers/kvm/driver.go, and a kvm_stub.go is used for unsupported architectures. In the registry Driver.Status(), move the arm64 check to front since there is no point in checking that libvirt is installed correctly if the driver is not supported yet.
The podman installation is now coming from Debian instead, and the cri-o package also includes conmon and crun now.
docs: Add vfkit and krunkit options in ISSUE_TEMPLATE (#21604)
kvm: remove dependency on external driver
CI: Update gh from 2.81.0 to 2.82.0
…gev1 test: Fix TestGetStoragev1 unit test on windows
…rykill test: fix TestTryKillOne unit test on windows
docs: Update auto-generated docs and translations
Remove old obsolete Podman kubic repository
In #20255 we added an option to use a configuration file instead of interactive mode, but the change broke interactive mode. Current minikube segfaults on start: % ./out/minikube addons configure registry-creds panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x2 addr=0x8 pc=0x1067603dc] goroutine 1 [running]: k8s.io/minikube/cmd/minikube/cmd/config.processRegistryCredsConfig({0x106858a06, 0x8}, 0x0) /Users/nir/src/minikube/cmd/minikube/cmd/config/configure_registry_creds.go:93 +0x2c k8s.io/minikube/cmd/minikube/cmd/config.init.func8(0x140001f2b00?, {0x140003a83a0, 0x1, 0x106850650?}) /Users/nir/src/minikube/cmd/minikube/cmd/config/configure.go:69 +0x24c github.com/spf13/cobra.(*Command).execute(0x10a088d40, {0x140003a8350, 0x1, 0x1}) /Users/nir/go/pkg/mod/github.com/spf13/cobra@v1.9.1/command.go:1019 +0x82c github.com/spf13/cobra.(*Command).ExecuteC(0x10a084880) /Users/nir/go/pkg/mod/github.com/spf13/cobra@v1.9.1/command.go:1148 +0x384 github.com/spf13/cobra.(*Command).Execute(...) /Users/nir/go/pkg/mod/github.com/spf13/cobra@v1.9.1/command.go:1071 k8s.io/minikube/cmd/minikube/cmd.Execute() /Users/nir/src/minikube/cmd/minikube/cmd/root.go:174 +0x550 main.main() /Users/nir/src/minikube/cmd/minikube/main.go:95 +0x250 The issue is that loadAddonConfigFile() returns nil if the --config-file flag is not specified, but the code expects non-nil config, handling zero value as interactive mode. Fixed by returning zero value config in this case. With this change we run the normal interactive flow: % ./out/minikube addons configure registry-creds Do you want to enable AWS Elastic Container Registry? [y/n]: n Do you want to enable Google Container Registry? [y/n]: n Do you want to enable Docker Registry? [y/n]: y -- Enter docker registry server url: docker.io -- Enter docker registry username: nirs -- Enter docker registry password: Do you want to enable Azure Container Registry? [y/n]: n ✅ registry-creds was successfully configured % out/minikube addons enable registry-creds ❗ registry-creds is a 3rd party addon and is not maintained or verified by minikube maintainers, enable at your own risk. ❗ registry-creds does not currently have an associated maintainer. ▪ Using image docker.io/upmcenterprises/registry-creds:1.10 🌟 The 'registry-creds' addon is enabled Note that this addon does not work on arm64 since we have only amd64 image. The pod fail to start: % kubectl logs deploy/registry-creds -n kube-system exec /registry-creds: exec format error
registry-creds: Fix segfault without config file
This change introduce the basic infrastructure for passing command line
options from the cmd/minikube/cmd package to other packages.
The cmd/flags package provides the CommandOptions() function returning
run.CommandOptions initialized using viper. This package keeps the
constants for command line options (e.g. "interactive") that we want to
share with various packages without accessing global state via viper.
To use options in drivers code, include CommandOptions in the
CommonDriver struct. The options will be initialized from the command
line options when creating a driver.
The basic idea is to create options in the command:
options := flags.CommandOptions()
And pass it to other packages, where code will use:
if options.NonInteractive {
Instead of:
if viper.GetBool("interactive") {
This is type safe and allows reliable parallel testing.
This fixes an obvious mis-wording in a warning message. Signed-off-by: Michael Adam <obnox@samba.org>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 6.0.0 to 6.1.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@4469467...4dc6199) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: 6.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7.0.8 to 7.0.9. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@271a8d0...84ae59a) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-version: 7.0.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
UI: improve warning message for proxy
docs: Update auto-generated docs and translations
…ctions/setup-go-6.1.0 Build(deps): Bump actions/setup-go from 6.0.0 to 6.1.0
…rsions_list build: Update Kubernetes versions list
build: Bump kubeadm constants for kubernetes images
…eter-evans/create-pull-request-7.0.9 Build(deps): Bump peter-evans/create-pull-request from 7.0.8 to 7.0.9
Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.1 to 6.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@93cb6ef...1af3b93) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.41.0 to 0.45.0. - [Commits](golang/crypto@v0.41.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
ci: add none driver tests to prow
…prow/minitest/golang.org/x/crypto-0.45.0 Build(deps): Bump golang.org/x/crypto from 0.41.0 to 0.45.0 in /hack/prow/minitest
…ctions/checkout-6.0.0 Build(deps): Bump actions/checkout from 5.0.1 to 6.0.0
docs: Update auto-generated docs and translations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )