[nextest-runner] add verbose flag to display test command lines #2800
Conversation
dangvu0502
changed the title
dangvu0502
force-pushed
the
feat/verbose-flag-command-display
branch
from
4cfe34a to
b00750c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2800 +/- ##
==========================================
+ Coverage 80.17% 80.19% +0.02%
==========================================
Files 113 113
Lines 26312 26359 +47
==========================================
+ Hits 21095 21139 +44
- Misses 5217 5220 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| fn default_builder() -> DisplayReporterBuilder { | ||
| DisplayReporterBuilder { | ||
| default_filter: CompiledDefaultFilter::for_default_config(), | ||
| status_levels: StatusLevels { | ||
| status_level: StatusLevel::Fail, | ||
| final_status_level: FinalStatusLevel::Fail, | ||
| }, | ||
| test_count: 5000, | ||
| success_output: Some(TestOutputDisplay::Immediate), | ||
| failure_output: Some(TestOutputDisplay::Immediate), | ||
| should_colorize: false, | ||
| no_capture: true, | ||
| verbose: false, | ||
| show_progress: ShowProgress::Counter, | ||
| no_output_indent: false, | ||
| max_progress_running: MaxProgressRunning::default(), | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Wouldn't this be better as an impl Default instead of a free standing fn?
| /// | ||
| /// Returns the output written to the reporter. | ||
| fn with_reporter<'a, F>(f: F, out: &'a mut String) | ||
| fn with_reporter<'a, F>(builder: DisplayReporterBuilder, f: F, out: &'a mut String) |
There was a problem hiding this comment.
If you're passing default_builder() at every call site isn't it just better to not have it as an argument and always construct a default builder inside the function?
sunshowers
left a comment
sunshowers
left a comment
There was a problem hiding this comment.
Thanks for working on this.
| fn write_test_command_line( | ||
| &self, | ||
| test_instance: &TestInstance<'a>, | ||
| writer: &mut dyn WriteStr, | ||
| ) -> io::Result<()> { | ||
| // Display the command line that will be used to run this test. | ||
| // Format: binary_path --exact test_name --nocapture [--ignored] | ||
| write!( | ||
| writer, | ||
| "{:>12} {} --exact {} --nocapture", | ||
| "COMMAND".style(self.styles.count), | ||
| test_instance.suite_info.binary_path, | ||
| test_instance.name, | ||
| )?; | ||
| if test_instance.test_info.ignored { | ||
| write!(writer, " --ignored")?; | ||
| } | ||
| writeln!(writer)?; | ||
|
|
||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
I think the command line (after wrapper scripts and target runners have been applied) should be sent as part of the event rather than being reconstructed here.
Also, this should use shell_words::join
| use smol_str::SmolStr; | ||
| use std::{num::NonZero, sync::Arc}; | ||
|
|
||
| fn default_builder() -> DisplayReporterBuilder { |
dangvu0502
force-pushed
the
feat/verbose-flag-command-display
branch
from
b00750c to
4c56227
Compare
|
Implementation updated based on feedback |
3 participants
Fixes #2513