Skip to content

Spike remove file plugin #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Spike remove file plugin #1379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
080b253
remove file plugin
aphralG Nov 7, 2025
a28e5fe
remove file plugin
aphralG Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions internal/file/file_manager_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ import (
)

//go:generate go run github.com/maxbrunsfeld/counterfeiter/v6@v6.8.1 -generate
//counterfeiter:generate . fileOperator
//counterfeiter:generate . FileOperatorInterface

//go:generate go run github.com/maxbrunsfeld/counterfeiter/v6@v6.8.1 -generate
//counterfeiter:generate . fileManagerServiceInterface
//counterfeiter:generate . FileManagerServiceInterface

const (
maxAttempts = 5
Expand All @@ -40,7 +40,7 @@ const (
)

type (
fileOperator interface {
FileOperatorInterface interface {
Write(ctx context.Context, fileContent []byte, fileName, filePermissions string) error
CreateFileDirectories(ctx context.Context, fileName string) error
WriteChunkedFile(
Expand All @@ -60,7 +60,7 @@ type (
MoveFile(ctx context.Context, sourcePath, destPath string) error
}

fileServiceOperatorInterface interface {
FileServiceOperatorInterface interface {
File(ctx context.Context, file *mpi.File, tempFilePath, expectedHash string) error
UpdateOverview(ctx context.Context, instanceID string, filesToUpdate []*mpi.File, configPath string,
iteration int) error
Expand All @@ -76,7 +76,7 @@ type (
UpdateClient(ctx context.Context, fileServiceClient mpi.FileServiceClient)
}

fileManagerServiceInterface interface {
FileManagerServiceInterface interface {
ConfigApply(ctx context.Context, configApplyRequest *mpi.ConfigApplyRequest) (writeStatus model.WriteStatus,
err error)
Rollback(ctx context.Context, instanceID string) error
Expand All @@ -98,8 +98,8 @@ type (
type FileManagerService struct {
manifestLock *sync.RWMutex
agentConfig *config.Config
fileOperator fileOperator
fileServiceOperator fileServiceOperatorInterface
fileOperator FileOperatorInterface
fileServiceOperator FileServiceOperatorInterface
// map of files and the actions performed on them during config apply
fileActions map[string]*model.FileCache // key is file path
// map of the files currently on disk, used to determine the file action during config apply
Expand Down
2 changes: 1 addition & 1 deletion internal/file/file_operator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ type FileOperator struct {
manifestLock *sync.RWMutex
}

var _ fileOperator = (*FileOperator)(nil)
var _ FileOperatorInterface = (*FileOperator)(nil)

// FileOperator only purpose is to write files,

Expand Down
Loading
Loading