fix: fixes env compatibility problem with container execution
#448
+6
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127
This change hardcodes the path to
bashwhen it is used within Docker. Ideally, we should be able to useenvto locatebash, it seems that some container execution platforms do not support it.Invoking
bashfrom the development, CI, or Ubuntu full installs will continue to use theenvpattern.This change builds off of this PR.
Proposed changes
common/docker-entrypoint.d/00-check-for-required-env.shfrom#!/usr/bin/env bashto#!/usr/bin/bashfor consistency and direct interpreter invocation.common/docker-entrypoint.shfrom#!/usr/bin/env bashto#!/usr/bin/bash.#!/usr/bin/bash) tocommon/docker-entrypoint.d/22-enable_js_fetch_trusted_certificate.shto ensure the script is executed with the correct shell.the supported keywords in this PR description (not in the title of the PR).Checklist
Before creating a pull request (PR), run through this checklist and mark each as complete:
README.md).