Skip to content

Refactor sequential select related members in AbstractEntityPersister #3373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2023
Merged

Refactor sequential select related members in AbstractEntityPersister #3373

merged 1 commit into from
Jul 23, 2023

Conversation

@bahusoid
Copy link
Member

@bahusoid bahusoid commented Jul 22, 2023 •
edited
Loading

  • Rename GetSubclassPropertyTableNumber(string propertyName, string entityName) with SingleTableEntityPersister specific logic to GetSubclassJoinPropertyTableNumber more adequate name for AbstractEntityPersister to avoid confusion with GetSubclassPropertyTableNumber(string propertyName)
  • Skip dictionary initialization logic if not required

@fredericDelaporte fredericDelaporte added this to the 5.5 milestone Jul 22, 2023
@bahusoid bahusoid merged commit e842cc5 into nhibernate:master Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

Assignees

No one assigned

Labels

c: Core p: Minor r: Fixed t: Improvement

Projects

None yet

Milestone

5.5

Development

Successfully merging this pull request may close these issues.

2 participants

@bahusoid @fredericDelaporte