Skip to content

manually fixed nipype2pydra converter issue where formatters are assigned as strings #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2025
Merged

manually fixed nipype2pydra converter issue where formatters are assigned as strings #68

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f70b8cf
made some threshold fields non-mandatory
tclose Sep 11, 2025
b61813a
Merge pull request #67 from nipype/mandatory-field-cleanup
tclose Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pydra/tasks/fsl/v6/maths/threshold.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,22 +77,28 @@ class Threshold(shell.Task["Threshold.Outputs"]):
use_nonzero_voxels: bool = shell.arg(
help="use nonzero voxels to calculate robust range",
requires=["use_robust_range"],
default=False,
)
in_file: File = shell.arg(
help="image to operate on", argstr="{in_file}", position=2
)
internal_datatype: ty.Any = shell.arg(
internal_datatype: str | None = shell.arg(
help="datatype to use for calculations (default is float)",
argstr="-dt {internal_datatype}",
position=1,
default=None,
)
output_datatype: ty.Any = shell.arg(
output_datatype: str | None = shell.arg(
help="datatype to use for output (default uses input type)",
argstr="-odt {output_datatype}",
position=-1,
default=None,
)
nan2zeros: bool = shell.arg(
help="change NaNs to zeros before doing anything", argstr="-nan", position=3
help="change NaNs to zeros before doing anything",
argstr="-nan",
position=3,
default=False,
)

class Outputs(shell.Outputs):
Expand Down