Skip to content

support for long.js #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

support for long.js #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1497770
support for long.js
lishengguo Aug 25, 2017
83f6531
test case from Long.fromNumber(0)
Oct 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/v2/encoder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ proto.writeInt = function (val) {
* ```
*/
proto.writeLong = function (val) {
if (typeof val !== 'number' && utility.isSafeNumberString(val)) {
if (typeof val !== 'number' && utility.isSafeNumberString(val + '')) {
Copy link
Member

@fengmk2 fengmk2 Aug 2, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detect val is not equal string first.

if (typeof val !== 'number') {
  if (typeof val !== 'string') {
    val = val + '';
  }
  if (utility.isSafeNumberString(val)) {
    val = Number(val);
  }
}

val = Number(val);
}

Expand Down
4 changes: 4 additions & 0 deletions test/long.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ describe('long.test.js', function () {
hessian.encode(java.long(0)),
new Buffer(['L'.charCodeAt(0), 0, 0, 0, 0, 0, 0, 0, 0])
);
assert.deepEqual(
hessian.encode(Long.fromNumber(0)),
new Buffer(['L'.charCodeAt(0), 0, 0, 0, 0, 0, 0, 0, 0])
);
});

it('should write and read equal java impl', function () {
Expand Down