Skip to content

chore(versioning): bump node to v24, pnpm to v10.20 #8289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(versioning): bump node to v24, pnpm to v10.20 #8289

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
013a196
chore(versioning): bump node to v24, pnpm to v10.20
avivkeller Oct 29, 2025
3b03516
update types
avivkeller Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/publish-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,6 @@ jobs:
use-version-file: true
registry-url: 'https://registry.npmjs.org'

- name: Re-install npm
# TODO: OIDC requires npm >=11.5.1.
# Until Node.js v24 is LTS (with npm 11 as the default), we need to bump.
run: npm install -g npm@11

- name: Publish
working-directory: packages/${{ matrix.package }}
run: |
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Copy link
Contributor

@bmuenzenmeyer bmuenzenmeyer Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd really prefer that we pin to a specific version.

Copy link
Member Author

@avivkeller avivkeller Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iiuc we only pinned to a specific version since we needed to be >= it. We support any v24.x, why do we need to pin to a specific one? (If we did, tho, I would assume it to be .11.0)

Original file line number Diff line number Diff line change
@@ -1 +1 @@
v22.14.0
v24
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,16 +52,16 @@
"typescript": "catalog:",
"typescript-eslint": "~8.45.0"
},
"packageManager": "pnpm@10.13.1",
"packageManager": "pnpm@10.20.0",
"devEngines": {
"runtime": {
"name": "node",
"version": ">=v22.14.0",
"version": ">=v24.11.0",
"onFail": "error"
},
"packageManager": {
"name": "pnpm",
"version": "10.13.1",
"version": "10.20.0",
"onFail": "error"
}
}
Expand Down
Loading
Loading