-
Notifications
You must be signed in to change notification settings - Fork 844
π§ chore(ci): upgrade python 3.13 #3112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,7 +27,7 @@ | |
| # - Retention configuration | ||
| # | ||
| # Required Inputs: | ||
| # - python-version: Python version for building (default: "3.10") | ||
| # - python-version: Python version for building (default: "3.11") | ||
| # - verify-package: Enable package verification (default: true) | ||
| # | ||
| # Outputs: | ||
|
|
@@ -46,7 +46,7 @@ | |
| # build: | ||
| # uses: ./.github/workflows/_reusable-artifact-builder.yaml | ||
| # with: | ||
| # python-version: "3.10" | ||
| # python-version: "3.11" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here |
||
| # verify-package: true | ||
| # | ||
| # Note: Requires proper Python project structure and build configuration | ||
|
|
@@ -59,7 +59,7 @@ on: | |
| python-version: | ||
| description: "Python version for building" | ||
| type: string | ||
| default: "3.10" | ||
| default: "3.11" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here? |
||
| verify-package: | ||
| description: "Run package verification" | ||
| type: boolean | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,7 +58,7 @@ | |
| # uses: ./.github/workflows/_reusable-release-validation.yaml | ||
| # with: | ||
| # version: "v1.2.3" | ||
| # python-version: "3.10" | ||
| # python-version: "3.11" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here |
||
| # secrets: | ||
| # codecov-token: ${{ secrets.CODECOV_TOKEN }} | ||
| # | ||
|
|
@@ -68,7 +68,7 @@ | |
| # uses: ./.github/workflows/_reusable-release-validation.yaml | ||
| # with: | ||
| # version: "v1.2.3-rc1" | ||
| # python-version: "3.10" | ||
| # python-version: "3.11" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and here. It would be great to have consistency
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My bad, would you prefer these examples/defaults to reflect the minimum supported version (reverting to |
||
| # allow-prerelease: true | ||
| # secrets: | ||
| # codecov-token: ${{ secrets.CODECOV_TOKEN }} | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||
| # Use of virtual environment is highy recommended | ||||||
|
||||||
| # Use of virtual environment is highy recommended | |
| # Use of virtual environment is highly recommended |
Copilot
AI
Nov 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conda create command syntax python>=3.10 is incorrect. Conda expects python=3.10 or python=3.13 but does not support constraint operators like >= in the package specification. This should be changed to a specific version like python=3.13 or python=3.10.
| yes | conda create -n anomalib_env python>=3.10 | |
| yes | conda create -n anomalib_env python=3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change?