PoP tests #379
Open
PoP tests #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
reviewed
Aug 25, 2025
Comment on lines
34
to
36
| Sudo: { | ||
| key: defaultAccounts.alice.address, | ||
| }, |
There was a problem hiding this comment.
I don't think we have sudo in polkadot and kusama
Author
There was a problem hiding this comment.
True, I will switch to governance origins
rockbmb
reviewed
Aug 25, 2025
| await fundAccount(peopleClient, defaultAccounts.alice.address) | ||
|
|
||
| const interveneTx = peopleClient.api.tx.mobRule.intervene(latestCaseIndex, { Truth: { True: null } }) | ||
| const sudoInterveneTx = peopleClient.api.tx.sudo.sudo(interveneTx) |
Collaborator
There was a problem hiding this comment.
Did you need Alice as sudo to be able to submit this extrinsic with a root origin?
Normally, this would be done by injecting the desired call/origin into the scheduler pallet's storage for execution next block, but the People chain does not have that pallet available (unless PoP changes that).
Alternatively, you can send an XCM Transact from the relay chain to the people chain containing this mobRule.intervene extrinsic.
Check out sendXcmFromRelayToPeople in packages/shared/src/people.ts.
Collaborator
|
Let me know when you want a review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E2E tests of PoP functionalities:
Bandersnatch keys used in the tests were generated with the script in this PR: paritytech/verifiable#24
These tests are made to work with this runtime: https://github.com/paritytech/individuality-runtimes/pull/2 built with config attribute "testing", needed to disable bulletin chain communication - to fix.