Skip to content

Conversation

@MVGRAO
Copy link

@MVGRAO MVGRAO commented Dec 3, 2025

Summary of changes
Migration plan added

Added a tracked todo list (via the workspace todo tool) to break the Jest → node:test migration into clear, verifiable steps so we can convert tests incrementally and show progress.
Package scripts for node:test and Windows linting

Added/updated npm scripts in package.json: a test:node example (runs node --test) and Windows-friendly helpers: fix:eol (normalize EOLs) and lint:win (runs stylelint then npx eslint ...) so you can run tests/lint on Windows without POSIX wrapper failures.
TypeScript/ESLint coverage fix

Updated tsconfig.json to include tests//* and scripts//* so the TypeScript ESLint parser (parserOptions.project) covers test and script files.
Added file-level ESLint disable comments to setup-env.ts to avoid setup-file-specific lint failures (dev-dep imports and class-count).
Repository EOL normalization & enforcement

Added .gitattributes to enforce LF for source files and prevent new CRLF commits.
Added normalize-line-endings.js and the npm run fix:eol script to convert CRLF → LF across the repo so ESLint linebreak-style errors are resolved.
Lint-rule compliance / script hardening

Updated the normalizer script to remove continue and replace console.log with process.stdout.write to satisfy ESLint rules (no-continue, no-console).
Converted target test files to LF line endings so npx eslint --fix and npm run lint:win can run with far fewer errors.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 3, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @MVGRAO!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@bradenmacdonald
Copy link
Contributor

Hi @MVGRAO, thanks! Could you please sign the CLA?

@bradenmacdonald
Copy link
Contributor

Relates to #2725

@mphilbrick211
Copy link

@MVGRAO hi there, and thanks for this contribution! Please let us know if you have any questions regarding completing a CLA form. Thanks!

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions Dec 3, 2025
@MVGRAO
Copy link
Author

MVGRAO commented Dec 4, 2025

@bradenmacdonald @mphilbrick211 I have submitted the form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Tests Run or CLA Signed

Development

Successfully merging this pull request may close these issues.

4 participants