-
Notifications
You must be signed in to change notification settings - Fork 170
Convert tests from Jest to node-test #2728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the pull request, @MVGRAO! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Hi @MVGRAO, thanks! Could you please sign the CLA? |
|
Relates to #2725 |
|
@bradenmacdonald @mphilbrick211 I have submitted the form |
Summary of changes
Migration plan added
Added a tracked todo list (via the workspace todo tool) to break the Jest → node:test migration into clear, verifiable steps so we can convert tests incrementally and show progress.
Package scripts for node:test and Windows linting
Added/updated npm scripts in package.json: a test:node example (runs node --test) and Windows-friendly helpers: fix:eol (normalize EOLs) and lint:win (runs stylelint then npx eslint ...) so you can run tests/lint on Windows without POSIX wrapper failures.
TypeScript/ESLint coverage fix
Updated tsconfig.json to include tests//* and scripts//* so the TypeScript ESLint parser (parserOptions.project) covers test and script files.
Added file-level ESLint disable comments to setup-env.ts to avoid setup-file-specific lint failures (dev-dep imports and class-count).
Repository EOL normalization & enforcement
Added .gitattributes to enforce LF for source files and prevent new CRLF commits.
Added normalize-line-endings.js and the npm run fix:eol script to convert CRLF → LF across the repo so ESLint linebreak-style errors are resolved.
Lint-rule compliance / script hardening
Updated the normalizer script to remove continue and replace console.log with process.stdout.write to satisfy ESLint rules (no-continue, no-console).
Converted target test files to LF line endings so npx eslint --fix and npm run lint:win can run with far fewer errors.