Skip to content

fix: Remove extra margin around body element #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arbrandes merged 1 commit into from
Sep 30, 2025
Merged

fix: Remove extra margin around body element #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/bulk-email-tool/text-editor/TextEditor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import 'tinymce/plugins/codesample';
import '@edx/tinymce-language-selector';

import contentUiCss from 'tinymce/skins/ui/oxide/content.css';
import contentCss from 'tinymce/skins/content/default/content.css';
import contentCss from 'tinymce/skins/content/default/content.css?raw';
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril Sep 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The !!raw-loader version of this was updating both the contentUiCss import and the contentCss import. Was the contentUiCss change not needed or should that have ?raw added too?

Copy link
Contributor

@arbrandes arbrandes Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I missed that. @Lunyachek?

Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lunyachek and I discussed this, and it definitely makes sense. I also found a Stack Overflow thread where ?raw is used for both TinyMCE style imports.

// We're also importing styles manually and later attach them to editor. `?raw` here means that we're not using 
// any kind of style-loader (webpack) and just want to import content of file as plain string
// This requires additional setup in webpack and might look different for other build systems
import contentCss from 'tinymce/skins/content/default/content.min.css?raw';
import contentUiCss from 'tinymce/skins/ui/oxide/content.min.css?raw';

New PR: #260


export default function TextEditor(props) {
const {
Expand Down
7 changes: 6 additions & 1 deletion webpack.dev.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,13 @@ const webpack5esmInteropRule = {
},
};

const rawAssetRule = {
resourceQuery: /raw/,
type: 'asset/source',
};

const otherRules = config.module.rules;

config.module.rules = [webpack5esmInteropRule, ...otherRules];
config.module.rules = [rawAssetRule, webpack5esmInteropRule, ...otherRules];

module.exports = config;
7 changes: 6 additions & 1 deletion webpack.prod.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,13 @@ const webpack5esmInteropRule = {
},
};

const rawAssetRule = {
resourceQuery: /raw/,
type: 'asset/source',
};

const otherRules = config.module.rules;

config.module.rules = [webpack5esmInteropRule, ...otherRules];
config.module.rules = [rawAssetRule, webpack5esmInteropRule, ...otherRules];

module.exports = config;