-
Notifications
You must be signed in to change notification settings - Fork 12
OEL-4278: Extending drupal attributes and fixes for proper html attributes. #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bd18e41
OEL-4278: Extending drupal attributes and fixes for proper html attri…
tibi2303 b9913c5
OEL-4278: Fix remaining attributes.
tibi2303 753bd00
OEL-4278: Fix tests.
tibi2303 f5bd03d
OEL-4278: Simplified jest render method.
tibi2303 172851a
OEL-4278: Added test cases for attributes.
tibi2303 4c8f96e
Merge branch 'development' into OEL-4278-#default#
tibi2303 3df73df
OEL-4278: Added undefined value in attr array.
tibi2303 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| const { DrupalAttribute } = require("drupal-attribute"); | ||
|
|
||
| /** | ||
| * Storybook-specific DrupalAttribute variant. | ||
| * | ||
| * Aligns the JS implementation with Drupal's PHP Attribute behavior by keeping | ||
| * empty-string attribute values (e.g. `hidden=""`) instead of dropping them. | ||
| */ | ||
| class StorybookDrupalAttribute extends DrupalAttribute { | ||
| toString() { | ||
| const components = []; | ||
|
|
||
| for (const key of this.keys()) { | ||
| let value = this.get(key); | ||
|
|
||
| if (value === null || value === undefined || value === false) { | ||
| continue; | ||
| } | ||
|
|
||
| if (value === true) { | ||
| components.push(key); | ||
| continue; | ||
| } | ||
|
|
||
| if (Array.isArray(value)) { | ||
| const filtered = value | ||
| .filter((v) => v !== null && v !== undefined && v !== "") | ||
| .map(String); | ||
|
|
||
| if (filtered.length === 0) { | ||
| continue; | ||
| } | ||
|
|
||
| value = filtered.join(" "); | ||
| } | ||
|
|
||
| if (value === key) { | ||
| components.push(key); | ||
| continue; | ||
| } | ||
|
|
||
| if (value === "") { | ||
| components.push(`${key}=""`); | ||
| continue; | ||
| } | ||
|
|
||
| components.push(`${key}="${String(value)}"`); | ||
| } | ||
|
|
||
| return components.length ? ` ${components.join(" ")}` : ""; | ||
| } | ||
| } | ||
|
|
||
| module.exports = { | ||
| StorybookDrupalAttribute, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.